Revert "test: test configure ninja" #30295
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 85dd9e8. `make test` should never change the current set of `configure` flags. Refs: nodejs#30033
nodejs-github-bot
added
the
build
|
Please 👍 this comment to approve fast-tracking, even without a full CI run. This currently breaks |
richardlau
approved these changes
Nov 6, 2019
gengjiawen
approved these changes
Nov 6, 2019
|
Landed in 3698031, thanks for the quick reviews! |
addaleax
added a commit
that referenced
this pull request
Nov 6, 2019
This reverts commit 85dd9e8. `make test` should never change the current set of `configure` flags. Refs: #30033 PR-URL: #30295 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 17, 2019
This reverts commit 85dd9e8. `make test` should never change the current set of `configure` flags. Refs: #30033 PR-URL: #30295 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 85dd9e8.
make testshould never change the current set ofconfigureflags.
Refs: #30033
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes